-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[catesian]: Type hints and code redability improvements #1724
Conversation
@twicki, @FlorianDeconinck: The great cleanup continues. Pulling out as much as I can from main...romanc:romanc/dace-bridge-no-sdfgs before switching tasks. @egparedes would you mind kicking off CSCS CI for us? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are yo aware of the mypy excludes here Line 170 in 6873a0e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for the pointer @havogt, I wasn't aware. I'll see what we can do there in a follow-up PR if that is okay with you. Meanwhile, I updated the branch with latest |
cscs-ci run default |
Description
This PR is split off the work for the new GT4Py - DaCe bridge, which should allow to expose control flow statements (
if
andwhile
) to DaCe to better use DaCe's analytics capabilities. This PR is concerned with adding type hints and generally improving code readability. Main parts aredaceir_builder.py
: early returns and renamed variablesdfg_builder.py
: type hints and early returnstasklet_codegen.py
: type hints and early returnsTaskletCodegen
was givensdfg_ctx
, which wasn't used. That parameter was thus removed.Parent issue: GEOS-ESM/NDSL#53
Requirements
Assumed to be covered by existing tests.
N/A