style[cartesian]: readability improvements and more type hints #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 27, 2024 17:38
This might have been used before or might have been a copy/paste thing. In any case, it's not used anymore now and the test totally fine removing that external.
Readability improvements and some easy to add type hints.
egparedes
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Style-wise looks good to me. I leave the proper code review to @FlorianDeconinck and @twicki
|
ping @FlorianDeconinck / @twicki |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR detaches a couple of cleanups in the dace backend from the in-progress gt4py/dace bridge: mostly readability improvements and some easy type hints. There's also the occasional unused variable / argument in here.
Requirements
N/A: mypy is happy with the new type hints
N/A
/cc @twicki @FlorianDeconinck I've been reading more code "outside my comfort zone" today leading to this small cleanup PR