feat[next]: Remove dace_iterator backend and pass_manager_legacy #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edopao
added a commit
that referenced
this pull request
Jan 22, 2025
PR #1753 removed the `dace_iterator` backend, that before existed by side of `dace_fieldview` backend. Code common to these two backends was placed in `dace_common` module. The current GTIR-DaCe backend supports both iterator view and field view flavors of the GTIR, so there is no need for a distinction at the top level of the backend module. This PR applies the following cleanup tasks: ``` runners/dace_common/dace_backend -> runners/dace_fieldview/sdfg_callable runners/dace_common/utility -> runners/dace_fieldview/utils runners/dace_common/workflow, runners/dace_fieldview/workflow -> runners/dace_fieldview/workflow runners/dace_fiedview/utility -> runners/dace_fieldview/gtir_sdfg_utils runners/dace_fieldview -> runners/dace ``` The module `runners/dace/workflow` was also split into sub-modules. A doc string was added to `runners/dace/workflow/__init__.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dace orchestration tests are temporarily skipped until #1742 is merged.
The dace backend with SDFG optimization is temporarily disabled in unit tests until #1639 is merged.
A second PR will reorganize the files in dace backend module.