feat[next]: Support for Array Api namespace as allocator #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
commented
Dec 5, 2024
havogt
commented
Dec 5, 2024
src/gt4py/next/allocators.py
Outdated
| allocator: FieldBufferAllocationUtil = actual_allocator, | ||
| device: core_defs.Device = device, | ||
| ) -> core_defs.NDArrayObject: | ||
| # TODO check how to get from FieldBufferAllocationUtil to FieldBufferAllocatorProtocol |
There was a problem hiding this comment.
- think about long names -> maybe rename to
NDArray... __copy__,__deepcopy__as_ndarray(allocator: ConcreteAllocator, copy: Optional[bool])- can
TensorBufferbe removed?
|
havogt
changed the title
havogt
changed the title
havogt
commented
Dec 20, 2024
| self.ndarray, | ||
| domain=self.domain, | ||
| dtype=self.dtype, | ||
| copy=True, # aligned_index??? |
There was a problem hiding this comment.
Actually this is a missing piece in the current implementation. We should probably provide this as a default in all functions.
havogt
commented
Dec 20, 2024
| def get_array_allocation_namespace( | ||
| allocator: Optional[FieldBufferAllocationUtil | core_defs.ArrayApiNamespace], | ||
| device: Optional[core_defs.Device] = None, | ||
| ) -> GTArrayAllocationNamespace: |
There was a problem hiding this comment.
Maybe put aligned_index here and add it as a default to the construction functions.
Same for device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Array API namespaces as allocators in
gtx.constructors. This allows e.g. to construct jax fields in non-hacky way.Additional:
__copy__,__deepcopy__to NDArrayField (with same memory layout as source Field)