Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional GPU benchmark scripts #16

Closed
wants to merge 24 commits into from
Closed

Additional GPU benchmark scripts #16

wants to merge 24 commits into from

Conversation

iomaganaris
Copy link
Contributor

@iomaganaris iomaganaris commented Feb 8, 2024 •
edited
Loading

  • Added benchmark scripts for P100 (based on the configuration of A100) and H100 GPUs
  • Fixed issue with regex when using --label-regex with sbench-analyze plot
  • Write each benchmark source code in benchmarks_source_code folder for easier inspection
  • Rename GPU kernel functions to corresponding implementation name
  • Removed deprecated gpu_timers parameter
  • Added --generate-line-info compilation option for nvcc to improve source code investigation in NSight Compute. (To be used with --import-source yes in ncu)

@iomaganaris
Fix regex filtering when creating plots
db2de8e
@iomaganaris
Drop deprecated gpu_timers argument
513c9f1
@iomaganaris
Added script for H100
cfcf9cf
@iomaganaris
Enabled code printing
142820b
@iomaganaris
Trying to give informative names to the kernels
cfeb794
@iomaganaris
Write the actual file with the code
790e1de
@iomaganaris
Open file for writing
f03caf9
@iomaganaris
Write str instead of bytecode
799e3e3
@iomaganaris
Print compilation command
d2ccc06
@iomaganaris
Make sure that content is flushed to file
c3938ef
@iomaganaris
Fix gpu_kernel name in vertical advection kernels
56bbcf4
@iomaganaris
Added P100 script
6d4828b
@iomaganaris
Small improvement in printing source code file of generated kernels
b9f211b
@iomaganaris
Revert changes in A100 script
28740ef
@iomaganaris
Merge remote-tracking branch 'my-fork/ioannmag/plot_fixes' into ioann…
3e94cc7 
…mag/debug_tests
@iomaganaris
Fixed extension
7309bff
@iomaganaris
Remove debug print
ca10adf
@iomaganaris
Reorder gpu benchmark scripts
a399322
@iomaganaris
Trying better block size for vec adv classic
ef15ac9
@iomaganaris
Trying better config for vertical advection in H100
cf6044c
@iomaganaris
Revert changes in the sharedmem implementation of veradv
6b1512e
@iomaganaris
Update hor dif configuration for H100
394292a
@iomaganaris
Add line info for use with ncu and --import-source yes
5731e9e
@iomaganaris
Merge branch 'ioannmag/debug_tests' into ioannmag/gpu_benchmarks
b7c0a5e
@fthaler
Copy link
Contributor

fthaler commented Apr 2, 2024

Could you please split these changes into multiple PRs for easier review? That is, one for the benchmark scripts, one for the fixes, one for the changed kernel names, and one for the updated naming of source files.

@iomaganaris iomaganaris marked this pull request as draft April 2, 2024 12:23
@iomaganaris
Copy link
Contributor Author

Could you please split these changes into multiple PRs for easier review? That is, one for the benchmark scripts, one for the fixes, one for the changed kernel names, and one for the updated naming of source files.

Good point 👍 I split this PR to the following ones:

@fthaler
Copy link
Contributor

fthaler commented Jun 24, 2024

This PR was split into #17, #18, #19, and #20, thus closing now.

@fthaler fthaler closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iomaganaris @fthaler