Skip to content

Commit

Permalink
Fix monitoring page registration races in tests (ydb-platform#8770)
Browse files Browse the repository at this point in the history
  • Loading branch information
snaury authored Sep 6, 2024
1 parent 96dfeb9 commit 154f927
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
7 changes: 2 additions & 5 deletions ydb/core/mon/sync_http_mon.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,8 @@ namespace NActors {
}

void TSyncHttpMon::Stop() {
if (IndexMonPage) {
IndexMonPage->ClearPages(); // it's required to avoid loop-reference
TBase::Stop();
IndexMonPage.Drop();
}
IndexMonPage->ClearPages(); // it's required to avoid loop-reference
TBase::Stop();
}

void TSyncHttpMon::Register(NMonitoring::IMonPage* page) {
Expand Down
1 change: 0 additions & 1 deletion ydb/core/testlib/actors/test_runtime.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ namespace NActors {
void TTestActorRuntime::TNodeData::Stop() {
if (Mon) {
Mon->Stop();
GetAppData<NKikimr::TAppData>()->Mon = nullptr;
}
TNodeDataBase::Stop();
}
Expand Down

0 comments on commit 154f927

Please sign in to comment.