Added CompileErrors counter

GrigoriyPA · Dec 7, 2024 · 7b58850 · 7b58850
1 parent 42bb193
commit 7b58850
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/ydb/core/fq/libs/row_dispatcher/format_handler/filters/filters_set.cpp b/ydb/core/fq/libs/row_dispatcher/format_handler/filters/filters_set.cpp
@@ -12,6 +12,7 @@ class TTopicFiltersSet : public ITopicFiltersSet {
 
         NMonitoring::TDynamicCounters::TCounterPtr ActiveFilters;
         NMonitoring::TDynamicCounters::TCounterPtr InFlightCompileRequests;
+        NMonitoring::TDynamicCounters::TCounterPtr CompileErrors;
 
         TCounters(NMonitoring::TDynamicCounterPtr counters)
             : Counters(counters)
@@ -23,6 +24,7 @@ class TTopicFiltersSet : public ITopicFiltersSet {
         void Register() {
             ActiveFilters = Counters->GetCounter("ActiveFilters", false);
             InFlightCompileRequests = Counters->GetCounter("InFlightCompileRequests", false);
+            CompileErrors = Counters->GetCounter("CompileErrors", true);
         }
     };
 
@@ -87,29 +89,26 @@ class TTopicFiltersSet : public ITopicFiltersSet {
                 return;
             }
 
+            Y_ENSURE(InFlightCompilationId, "Unexpected completion response");
+            InFlightCompilationId = 0;
+            Self.Counters.InFlightCompileRequests->Dec();
+
             if (!ev->Get()->ProgramHolder) {
                 auto status = TStatus(ev->Get()->Status, std::move(ev->Get()->Issues));
                 LOG_ROW_DISPATCHER_ERROR("Filter compilation error: " << status.ToString());
+
+                Self.Counters.CompileErrors->Inc();
                 Consumer->OnFilteringError(status.AddParentIssue("Filed to compile purecalc program"));
                 return;
             }
 
             Y_ENSURE(PurecalcFilter, "Unexpected completion response for client without filter");
             LOG_ROW_DISPATCHER_TRACE("Filter compilation finished");
-
-            Self.Counters.ActiveFilters->Inc();
-            PurecalcFilter->OnCompileResponse(std::move(ev));
-            Consumer->OnFilterStarted();
-            InFlightCompilationId = 0;
+            StartFilter();
         }
 
     private:
         void StartFilter() {
-            if (InFlightCompilationId) {
-                InFlightCompilationId = 0;
-                Self.Counters.InFlightCompileRequests->Dec();
-            }
-
             FilterStarted = true;
             Self.Counters.ActiveFilters->Inc();
             Consumer->OnFilterStarted();