Fix UB in right shift (ydb-platform#10422)

GrigoriyPA · Oct 16, 2024 · a4c9ddf · a4c9ddf
1 parent 0025e00
commit a4c9ddf
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/ydb/library/yql/udfs/common/ip_base/lib/ip_base_udf.h b/ydb/library/yql/udfs/common/ip_base/lib/ip_base_udf.h
@@ -95,8 +95,7 @@ namespace {
         }
 
         static TRawIp6 MaskFromPrefix(ui8 prefix) {
-            ui128 x = ui128(-1) << int(128 - prefix);
-            if (prefix == 0) x = 0;
+            ui128 x = prefix == 0 ? ui128(0) : ui128(-1) << int(128 - prefix);
             return FromIpAddress({x, TIpv6Address::Ipv6});
         }