Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nil operation on EQ/NEQ/IN/NOT_IN #112

Merged
merged 8 commits into from
Sep 2, 2024
Merged

feat: add nil operation on EQ/NEQ/IN/NOT_IN #112

merged 8 commits into from
Sep 2, 2024

Conversation

coanor
Copy link
Contributor

@coanor coanor commented Sep 2, 2024

Close #111.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

filter/eval.go Outdated Show resolved Hide resolved
filter/eval.go Show resolved Hide resolved
@guance-review-bot guance-review-bot bot added size/L and removed size/M labels Sep 2, 2024
@vircoys
Copy link
Contributor

vircoys commented Sep 2, 2024

/approve

@guance-review-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coanor, vircoys

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coanor
Copy link
Contributor Author

coanor commented Sep 2, 2024

/lgtm

@guance-review-bot
Copy link

@coanor: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vircoys
Copy link
Contributor

vircoys commented Sep 2, 2024

/lgtm

@coanor coanor merged commit d8cd829 into main Sep 2, 2024
1 of 3 checks passed
@coanor coanor deleted the 111-iss-nil-op branch September 2, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add nil/null operation for point filter
3 participants