fix: fix hang on bad datafile #53
Conversation
If there was a bad datafile(0 byte size datafile or invalid data header), the cache Get() will always stand on the bad file.
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coanor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coanor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
diskcache/get.go
Outdated
| droppedBatchVec.WithLabelValues(c.path, reasonBadDataFile).Inc() | ||
| }() | ||
|
|
||
| if err := c.removeCurrentReadingFile(); err != nil { |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coanor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coanor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If there was a bad datafile(0 byte size datafile or invalid data header), the cache Get() will always stand on the bad file.
On the fix, we just skip these bad file(switch to next read-pending file).