Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add grafana variable supports #42

Merged
merged 3 commits into from
Nov 16, 2023
Merged

feat: Add grafana variable supports #42

merged 3 commits into from
Nov 16, 2023

Conversation

yufeiminds
Copy link
Contributor

@yufeiminds yufeiminds commented Nov 16, 2023 •
edited
Loading

Fixes #37
Fixes #36

@guance-review-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yufeiminds

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guance-review-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yufeiminds

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guance-review-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yufeiminds

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guance-review-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yufeiminds

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yufeiminds yufeiminds merged commit 0e766e2 into main Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coanor coanor Awaiting requested review from coanor

@livesiteme livesiteme Awaiting requested review from livesiteme

Assignees
No one assigned
Labels
approved size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supports discovery Grafana dashboards Supports Grafana template variables
1 participant
@yufeiminds