Windows: allow recovering from performance counter errors #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the CPU performance counters cannot be opened because the performance counter registry is in an invalid state, recreate the query at the next CPU information refresh, adding a request to the performance library to reload the performance counter registry.
GuillaumeGomez
approved these changes
Nov 13, 2024
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1381
If another program is updating the performance counters registry, CPU performance counters cannot be opened because the performance counter registry is in an invalid state.
When it happens, recreate the performance counter query at the next refresh of CPU information, adding a request to reload performance counter information from the registry (without this request, the performance counter library caches the registry data internally).