refactor: 의존성 배열 문제로 controlHeader 함수를 useEffect 안에 넣어주기

#40
Gyeongdan · Jul 16, 2024 · 2c9dbd8 · 2c9dbd8
1 parent d9a5484
commit 2c9dbd8
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/components/Header.tsx b/src/components/Header.tsx
@@ -11,16 +11,16 @@ const Header = () => {
   const [show, setShow] = useState(true);
   const [lastScrollY, setLastScrollY] = useState(0);
 
-  const controlHeader = () => {
-    if (window.scrollY > lastScrollY) {
-      setShow(false);
-    } else {
-      setShow(true);
-    }
-    setLastScrollY(window.scrollY);
-  };
-
   useEffect(() => {
+    const controlHeader = () => {
+      if (window.scrollY > lastScrollY) {
+        setShow(false);
+      } else {
+        setShow(true);
+      }
+      setLastScrollY(window.scrollY);
+    };
+
     window.addEventListener('scroll', controlHeader);
 
     return () => {