Add missing public getters and setters to various classes #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrax
reviewed
Mar 29, 2024
|
I'm noticing now that the first few commits of this PR overlap with #253. The other PR should probably be merged first, then I can rebase this PR to drop the redundant changes. |
dgelessus
force-pushed
the
add_missing_getters_setters
branch
from
8ae6575 to
6a5aaa8
Compare
zrax
reviewed
Mar 2, 2025
core/PRP/Avatar/plArmatureMod.h
Outdated
|
|
||
| public: | ||
| plKey getDefaultMesh() const { return fDefaultMesh; } | ||
| ST::string getRootName() const { return fRootName; } |
There was a problem hiding this comment.
I would probably return strings as references, since they will potentially invoke a deep copy otherwise
There was a problem hiding this comment.
Makes sense. Most existing getters return ST::string by copy though (which is why I did the same thing initially).
dgelessus
force-pushed
the
add_missing_getters_setters
branch
from
6a5aaa8 to
0fd72a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes were already fully implemented, but had no public API beyond the basic read/write methods, so there was no way to interact with them outside libHSPlasma. This PR adds getters and setters where appropriate and converts some classes to public structs.
This is a somewhat random selection of classes (I was experimenting with PrpShop and these are the ones I stumbled across). There are probably still more places that could use the same treatment.