This repository has been archived by the owner on Sep 15, 2024. It is now read-only.
Refactor & Fix UI/UX Page [Markdown] [LaTex] [WIP] #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CodeQL analysis is complete for PR #146 |
[+] refactor(markdown.tsx): remove unused escapeDollarMathNumber function [+] fix(markdown.tsx): fix escaping of single dollar sign followed by a number
[+] fix(markdown.tsx): escape single dollar sign followed by a number in escapeDollarNumber function [+] chore(markdown.tsx): add comment to explain the purpose of isInMathExpression variable
|
Caution It's going bad if removing HTML Entity Dollar Signs + breaking a rendering looks like lagging |
Caution It's going bad if removing HTML Entity Dollar Signs + breaking a rendering looks like lagging |
H0llyW00dzZ
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[+] refactor(markdown.tsx): remove unused escapeDollarMathNumber function
[+] fix(markdown.tsx): fix escaping of single dollar sign followed by a number
Tip
Usage (
$...$) or ($$...$$)Note
This removing HTML Entity Dollar Signs