ASA 7231 #131
Merged
ASA 7231 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripajoym
reviewed
Jan 23, 2024
| @@ -59,7 +59,9 @@ public interface IScanServiceProvider { | |||
| * @throws JSONException If an error occurs. | |||
| */ | |||
| public JSONObject getScanDetails(String scanId) throws IOException, JSONException; | |||
|
|
|||
|
|
|||
| public String getScanExecutionName(); | |||
kripajoym
reviewed
Jan 23, 2024
|
|
||
| @Override | ||
|
|
||
| @Override |
There was a problem hiding this comment.
No need for override if you remove the method from Interface.
kripajoym
reviewed
Jan 23, 2024
| @@ -55,6 +55,9 @@ public String createAndExecuteScan(String type, Map<String, String> params) { | |||
| public String createAndExecuteScanWithJSONParameter(String type, JSONObject params) { | |||
| return ""; | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
And we can remove it from the ASE Provider as well.
kripajoym
approved these changes
Jan 24, 2024
mattmurp
reviewed
Jan 24, 2024
| @@ -179,15 +179,17 @@ public JSONObject getScanDetails(String scanId) throws IOException, JSONExceptio | |||
| if(loginExpired()) | |||
| return null; | |||
|
|
|||
| String request_url = m_authProvider.getServer() + String.format(API_BASIC_DETAILS, scanId); | |||
| String request_url = m_authProvider.getServer() + API_BASIC_DETAILS; | |||
| request_url += "?$filter=Id eq " +String.format("%s",scanId); | |||
There was a problem hiding this comment.
Is there a reason to use String.format() here as opposed to just using the scanId directly? If there's a need to use String.format(), I suggest using the full string "?$filter=Id eq %s" instead of appending to that value.
There was a problem hiding this comment.
Sure, Matt. Now, I am appending the following string in the request_url: String.format("?$filter=Id eq %s",scanId).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handled the report name issue