Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA 8392 #155

Merged
merged 10 commits into from
Jun 4, 2024
Merged

Conversation

vishalhcl-5960
Copy link

https://jira02.hclpnp.com/browse/ASA-8392 - As a DevOps Engineer, I want to automate DAST Scan execution in AppScan 360 via HCL AppScan Jenkins Plugin.

@vishalhcl-5960 vishalhcl-5960 requested a review from kripajoym June 3, 2024 10:14
Copy link

@mattmurp mattmurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these changes belong in the SDK. The plugins should handle messaging to the user for specific scenarios. It's also not clear why a client would be able to get so far as to validate the url for a DAST scan if they don't have the ability to run DAST scans.
The last change for validating a url with an invalid certificate could be useful.

Copy link

@kripajoym kripajoym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you have maintained the indentation

@vishalhcl-5960
Copy link
Author

I don't think these changes belong in the SDK. The plugins should handle messaging to the user for specific scenarios. It's also not clear why a client would be able to get so far as to validate the url for a DAST scan if they don't have the ability to run DAST scans. The last change for validating a url with an invalid certificate could be useful.

Sure Matt, I am now doing the URL validity for AppScan360 in the plugin. We don't any reliable way to get the A360 instance version because of that we are showing the users a generic message.

@vishalhcl-5960 vishalhcl-5960 merged commit 1146784 into HCL-TECH-SOFTWARE:ASA-8392 Jun 4, 2024
2 checks passed
vishalhcl-5960 added a commit that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants