Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review comments #160

Merged
merged 14 commits into from
Jun 13, 2024
Merged

Conversation

vishalhcl-5960
Copy link

Addressed the #158 PR review comments

@vishalhcl-5960 vishalhcl-5960 requested a review from kripajoym June 13, 2024 11:55
@vishalhcl-5960 vishalhcl-5960 merged commit 9b5a123 into HCL-TECH-SOFTWARE:ASA-8404 Jun 13, 2024
2 checks passed
vishalhcl-5960 added a commit to vishalhcl-5960/appscan-sdk that referenced this pull request Jun 17, 2024
* include SCA implementation
* review changes
mattmurp pushed a commit that referenced this pull request Jun 24, 2024
* ASA 8404 (#158)

* include SCA implementation
* copyright changes

* review comments (#160)

* include SCA implementation
* review changes

* Update ASoCScan.java

* white space handling

* Update SAClient.java

* Update CoreConstants.java

* Include SCA

* removed the OSO option

* Include SCA

* ASA-8404

* include SCA implementation

* updated console logs

* Update SAClient.java

* copyright changes

* review changes

* indentation

* Update CoreConstants.java

* indentation

* ASA 8404 (#158)

* include SCA implementation
* copyright changes

* Update SAClient.java

* review comments (#160)

* include SCA implementation
* review changes

* Update ASoCScan.java

* white space handling

* Update SAClient.java

* Update CoreConstants.java

* Update SAClient.java

* active subscription check

* Matt's commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant