-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LOG VOL CI not including Zlib #5181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the workflow was already explicitly turning off zlib support before, we need to determine why the default being changed to OFF is now causing the LOG VOL CI to fail and fix that issue, rather than enabling zlib support to paper over the issue.
The workflow wasn't explicitly turning off zlib before. It used to include zlib by default like everything else. In the PR that changed the zlib default to off, the "ZLIB=OFF" line was redundantly added to the workflow. That should have been ZLIB=ON. |
I don't believe the line was redundant; more that it was either a copy-paste or wasn't functioning as intended before. Either way, this still seems to point to an issue that needs to be fixed on the LOG VOL's side before re-enabling ZLIB. Otherwise, the issue will go unfixed. @brtnfld do you happen to know anything about this? |
I'm unaware of how zlib is being tested in the log-vol; I've created an issue HDFGroup/vol-log-based#75 to determine what's happening. |
#5085 changed the default for zlip support to 'off', so the CI should now specifically turn this one. The LOG VOL CI is currently failing two compression tests due to this issue.