Move AWS config/auth code inside H5FDs3comms.c #5238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 14, 2025 17:47
* Better location for HTTP verb allocation * Shove all auth setup into the same if statement * strcpy() instead of memcpy() to copy strings * Other minor renaming and comment cleanup
For parity with the same field in the fapl
Better than unsigned char
* Adds H5FD_s3comms_make_iso_8661_string() and moves associated functionality inside. * Removes gmnow() function * Removes unused RFC-7231 macros
All AWS configuration and authentication logic is now centralized in H5FDs3comms.c. This will make it easier to load config data from AWS environment variables, AWS config files, and fapl parameters.
derobins
added
Priority - 1. High 🔼
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
changed the title
added 2 commits
January 15, 2025 04:54
byrnHDF
approved these changes
Jan 15, 2025
lrknox
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS configuration and authorization setup code needs to be
consolidated into one location in order to check AWS environment
variables and configuration files as well as fapl parameters.
This changeset pushes some stragglers into the s3comms code.
Also includes some cleanup, like removing useless macros,
making the s3comms functions package functions, and
renames things for symmetry and readability.