Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable S3 VFD Test for Windows CI #5247

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Enable S3 VFD Test for Windows CI #5247

wants to merge 3 commits into from

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Jan 17, 2025

No description provided.

@byrnHDF byrnHDF added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality Component - Misc Anything else (CODEOWNERS, etc.) labels Jan 17, 2025
@byrnHDF
Copy link
Contributor

byrnHDF commented Feb 3, 2025

I think I would prefer that instead of modifying this workflow to create a new vcpkg workflow - vcpkg-cmake.yml.
And then we can specify vcpg (https://github.com/microsoft/vcpkg ) specifid tests.

byrnHDF
byrnHDF requested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@byrnHDF byrnHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create vcpkg workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF requested changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Component - Misc Anything else (CODEOWNERS, etc.) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyoklee @byrnHDF