Move TestAlarmOn()/TestAlarmOff() back into PerformTests() #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves call to TestAlarmOn() in testframe framework back into the PerformTests() function due to the timing of when the framework processes command-line arguments
jhendersonHDF
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
jhendersonHDF
commented
Feb 10, 2025
| @@ -456,6 +450,10 @@ TestParseCmdLine(int argc, char *argv[]) | |||
| herr_t | |||
| PerformTests(void) | |||
| { | |||
| /* Enable alarm timer for tests */ | |||
| if (TestAlarmOn() < 0) | |||
There was a problem hiding this comment.
While I'd like for this timer to cover essentially the whole test program, the timing of when testframe tests process command-line arguments means that this call has to come late in test execution to react to the -testexpress command-line option. The timer is still for all of the tests as intended in #5292, but not for the init/shutdown parts of the program. To cover that as well, TestParseCmdLine() would need to be called as part of TestInit(), which would be a good idea but would require re-writing how that function deals with skipping tests, so this is the easier solution for now.
jhendersonHDF
added
Priority - 3. Low 🔽
byrnHDF
approved these changes
Feb 10, 2025
lrknox
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves call to TestAlarmOn() in testframe framework back into the PerformTests() function due to the timing of when the framework processes command-line arguments