Support running tests against HDF5 2.0.0 with CMake builds #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mattjala
commented
Nov 18, 2024
mattjala
commented
- If the REST VOL is built against HDF5 >= 2.0.0, update the random datatype generator to avoid generating complex datatypes
- Disable running tests with autotools against HDF5 develop, since HDF5 >= 2.0.0 doesn't support autotools builds
| @@ -1161,6 +1161,9 @@ else | |||
| enable_static=no | |||
| fi | |||
|
|
|||
| # Autotools build isn't supported by HDF5 >= 2.0.0, so assume HDF5 version is < 2.0.0 | |||
| AC_DEFINE([HDF5_2], [0], [Whether HDF5 version is at least 2.0.0]) | |||
There was a problem hiding this comment.
Since Autotools builds are still supported in develop, I think we should keep testing until the Autotools code is removed
jhendersonHDF
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.