ECal endcap turbine topological clustering #137
+475
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix conflicts with main branch
Fix conflicts with main branch
RecFCCeeCalorimeter/src/components/CreateFCCeeCaloNeighbours.cpp
Outdated
Show resolved
Hide resolved
RecFCCeeCalorimeter/src/components/CreateFCCeeCaloNeighbours.cpp
Outdated
Show resolved
Hide resolved
RecFCCeeCalorimeter/src/components/CreateFCCeeCaloNeighbours.cpp
Outdated
Show resolved
Hide resolved
RecFCCeeCalorimeter/tests/options/run_thetamodulemerged_SW_benchmarkCorr.py
Outdated
Show resolved
Hide resolved
|
Hi @giovannimarchiori , I think I've managed to un-screw-up this PR. The files changed page now only shows the code that I intended to alter. Please have another look. Thanks, |
RecFCCeeCalorimeter/src/components/CreateFCCeeCaloNeighbours.cpp
Outdated
Show resolved
Hide resolved
RecFCCeeCalorimeter/src/components/CreateFCCeeCaloNeighbours.cpp
Outdated
Show resolved
Hide resolved
RecFCCeeCalorimeter/src/components/CreateFCCeeCaloNeighbours.cpp
Outdated
Show resolved
Hide resolved
RecFCCeeCalorimeter/src/components/CreateFCCeeCaloNeighbours.cpp
Outdated
Show resolved
Hide resolved
RecFCCeeCalorimeter/src/components/CreateFCCeeCaloNeighbours.cpp
Outdated
Show resolved
Hide resolved
added 3 commits
March 3, 2025 16:06
added 6 commits
March 3, 2025 16:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Add support for topological clustering in the "turbine" ECal endcap, including the code needed for creating neighbor and noise maps. Note that at the moment the noise maps are not real, they just contain a small non-zero value in every cell to allow the algorithm to run.
This PR is dependent on a corresponding PR for k4geo: key4hep/k4geo#426
ENDRELEASENOTES