Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added & refactored sharing endpoints #29

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat: Added & refactored sharing endpoints #29

merged 1 commit into from
Oct 11, 2023

Conversation

frederikpyt
Copy link
Contributor

@frederikpyt frederikpyt commented Oct 11, 2023

Description

  • Added a /api/item/shared endpoint
    • This returns all items which are shared to the user calling the endpoint
  • Added a /api/item/:id/sharings endpoint
    • This returns all the sharings of an item and the owner
  • Refactored the add sharing endpoint to use email instead of userId

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 3:40pm

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/bin/git' failed with exit code 128
St.
Category Percentage Covered / Total
🟢 Statements 100% 835/835
🟢 Branches 100% 105/105
🟢 Functions 100% 146/146
🟢 Lines 100% 799/799

Test suite run success

201 tests passing in 37 suites.

Report generated by 🧪jest coverage report action from db0de0e

@frederikpyt frederikpyt self-assigned this Oct 11, 2023
@kristianbinau kristianbinau linked an issue Oct 11, 2023 that may be closed by this pull request
Copy link
Member

@kristianbinau kristianbinau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️ Nice work!

@frederikpyt frederikpyt merged commit aa832f4 into master Oct 11, 2023
5 checks passed
@frederikpyt frederikpyt deleted the fmp-27 branch October 11, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing items
2 participants