Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Generate client upload token #3

Merged
merged 1 commit into from
Sep 29, 2023
Merged

feat: Generate client upload token #3

merged 1 commit into from
Sep 29, 2023

Conversation

frederikpyt
Copy link
Contributor

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@frederikpyt frederikpyt self-assigned this Sep 26, 2023
@vercel
Copy link

vercel bot commented Sep 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 6:52am

@frederikpyt frederikpyt changed the title #2 - WIP feat: Generate client upload token Sep 26, 2023
@frederikpyt frederikpyt linked an issue Sep 27, 2023 that may be closed by this pull request
Creation of client upload route #2
Closed
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 303/303
🟢 Branches 100% 20/20
🟢 Functions 100% 58/58
🟢 Lines 100% 286/286
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / plainText.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / item.route.ts
 100% 100% 100% 100%
🟢
... / item.controller.ts
 100% 100% 100% 100%
🟢
... / item.service.ts
 100% 100% 100% 100%
🟢
... / blob.service.ts
 100% 100% 100% 100%
🟢
... / item.schema.ts
 100% 100% 100% 100%

Test suite run success

48 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from 67c4593

kristianbinau
kristianbinau requested changes Sep 28, 2023
View reviewed changes
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
prisma/schema.prisma Outdated Show resolved Hide resolved
src/modules/item/blob.service.ts Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
src/modules/item/item.schema.ts Outdated Show resolved Hide resolved
kristianbinau

This comment was marked as outdated.

Sign in to view

@kristianbinau kristianbinau self-requested a review September 28, 2023 16:01
kristianbinau
kristianbinau requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@kristianbinau kristianbinau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests

kristianbinau
kristianbinau approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@kristianbinau kristianbinau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@frederikpyt frederikpyt merged commit 8f82485 into master Sep 29, 2023
5 checks passed
@frederikpyt frederikpyt deleted the fmp-2 branch September 29, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristianbinau kristianbinau kristianbinau approved these changes

Assignees

@frederikpyt frederikpyt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creation of client upload route
2 participants
@frederikpyt @kristianbinau