Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Item endpoints #32

Merged
merged 5 commits into from
Oct 17, 2023
Merged

feat: Added Item endpoints #32

merged 5 commits into from
Oct 17, 2023

Conversation

Anders164a
Copy link
Contributor

@Anders164a Anders164a commented Oct 16, 2023 •
edited
Loading

Description

Added new item endpoint to get a single item, with all includes.
This was introduced for the Shortcut view in web

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 8:47am

@Anders164a Anders164a self-assigned this Oct 17, 2023
@Anders164a Anders164a linked an issue Oct 17, 2023 that may be closed by this pull request
Shortcuts #31
Closed
@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 918/918
🟢 Branches 100% 115/115
🟢 Functions 100% 178/178
🟢 Lines 100% 879/879

Test suite run success

209 tests passing in 38 suites.

Report generated by 🧪jest coverage report action from c5c5563

frederikpyt
frederikpyt requested changes Oct 17, 2023
View reviewed changes
src/modules/item/item.schema.ts Outdated Show resolved Hide resolved
src/modules/item/item.service.ts Show resolved Hide resolved
src/modules/item/item.controller.ts Outdated Show resolved Hide resolved
src/modules/item/__test__/item.read.test.ts Outdated Show resolved Hide resolved
src/modules/item/__test__/item.read.test.ts Outdated Show resolved Hide resolved
src/modules/item/item.service.ts Outdated Show resolved Hide resolved
@frederikpyt
Copy link
Contributor

Also missing PR description

frederikpyt
frederikpyt requested changes Oct 17, 2023
View reviewed changes
src/modules/item/item.route.ts Outdated Show resolved Hide resolved
src/modules/item/item.service.ts Outdated Show resolved Hide resolved
src/modules/item/item.service.ts Outdated Show resolved Hide resolved
frederikpyt
frederikpyt approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@frederikpyt frederikpyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTH🤷🏻

@Anders164a Anders164a merged commit 87e7406 into master Oct 17, 2023
5 checks passed
@Anders164a Anders164a deleted the ara-31 branch October 17, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikpyt frederikpyt frederikpyt approved these changes

Assignees

@Anders164a Anders164a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortcuts
2 participants
@Anders164a @frederikpyt