Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added i18n to backend #4

Merged
merged 5 commits into from
Sep 28, 2023
Merged

feat: Added i18n to backend #4

merged 5 commits into from
Sep 28, 2023

Conversation

Anders164a
Copy link
Contributor

@Anders164a Anders164a commented Sep 27, 2023 •
edited
Loading

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@Anders164a Anders164a self-assigned this Sep 27, 2023
@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 8:39am

@Anders164a Anders164a linked an issue Sep 27, 2023 that may be closed by this pull request
Setup i18n #1
Closed
@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 243/243
🟢 Branches 100% 12/12
🟢 Functions 100% 48/48
🟢 Lines 100% 230/230
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢 plugins/i18n.ts 100% 100% 100% 100%
🟢
... / error.handler.ts
 100% 100% 100% 100%

Test suite run success

40 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 091940d

frederikpyt
frederikpyt requested changes Sep 27, 2023
View reviewed changes
src/index.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/locales/da.json Outdated Show resolved Hide resolved
src/locales/da.json Outdated Show resolved Hide resolved
src/modules/auth/auth.schema.ts Show resolved Hide resolved
src/modules/auth/auth.schema.ts Show resolved Hide resolved
src/modules/auth/__test__/login.test.ts Outdated Show resolved Hide resolved
src/modules/auth/__test__/login.test.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
kristianbinau
kristianbinau requested changes Sep 27, 2023
View reviewed changes
src/locales/da.json Outdated Show resolved Hide resolved
src/locales/da.json Outdated Show resolved Hide resolved
src/modules/auth/__test__/register.test.ts Outdated Show resolved Hide resolved
kristianbinau
kristianbinau requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@kristianbinau kristianbinau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently do not test setting the header to change the language, I think that would be good too have

frederikpyt
frederikpyt requested changes Sep 28, 2023
View reviewed changes
src/locales/da.json Outdated Show resolved Hide resolved
src/modules/auth/auth.route.ts Outdated Show resolved Hide resolved
frederikpyt
frederikpyt approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@frederikpyt frederikpyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you @kristianbinau

kristianbinau
kristianbinau approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@kristianbinau kristianbinau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@kristianbinau kristianbinau merged commit b92e6f1 into master Sep 28, 2023
5 checks passed
@kristianbinau kristianbinau deleted the ara-1 branch September 28, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikpyt frederikpyt frederikpyt approved these changes

@kristianbinau kristianbinau kristianbinau approved these changes

Assignees

@Anders164a Anders164a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup i18n
3 participants
@Anders164a @kristianbinau @frederikpyt