Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reverted to using npm #6

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: Reverted to using npm #6

merged 1 commit into from
Sep 27, 2023

Conversation

frederikpyt
Copy link
Contributor

Description

  • Reverted back to using npm

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@frederikpyt frederikpyt self-assigned this Sep 27, 2023
@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 9:07pm

@frederikpyt frederikpyt linked an issue Sep 27, 2023 that may be closed by this pull request
Revert to npm #5
Closed
@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 224/224
🟢 Branches 100% 9/9
🟢 Functions 100% 44/44
🟢 Lines 100% 212/212

Test suite run success

37 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 48c8d3b

kristianbinau
kristianbinau requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@kristianbinau kristianbinau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to using node 18 as this is what Vercel will be deployed as.

kristianbinau
kristianbinau approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@kristianbinau kristianbinau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jubii (i reviewed this from the toilet!)

IMG_20230927_230858.jpg

@frederikpyt frederikpyt merged commit 8218f36 into master Sep 27, 2023
5 checks passed
@frederikpyt frederikpyt deleted the fmp-5 branch September 27, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristianbinau kristianbinau kristianbinau approved these changes

Assignees

@frederikpyt frederikpyt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert to npm
2 participants
@frederikpyt @kristianbinau