Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added breadcrumb #39

Merged
merged 4 commits into from
Oct 18, 2023
Merged

feat: Added breadcrumb #39

merged 4 commits into from
Oct 18, 2023

Conversation

frederikpyt
Copy link
Contributor

@frederikpyt frederikpyt commented Oct 18, 2023 •
edited
Loading

Description

  • Added breadcrumb

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@frederikpyt frederikpyt self-assigned this Oct 18, 2023
@vercel
Copy link

vercel bot commented Oct 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 9:59am

@frederikpyt frederikpyt linked an issue Oct 18, 2023 that may be closed by this pull request
Breadcrumb #21
Closed
@frederikpyt frederikpyt requested review from Anders164a and removed request for kristianbinau October 18, 2023 09:10
Anders164a
Anders164a requested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@Anders164a Anders164a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is okay

But as the second user "Shared with me" returns the user to "My files"

@frederikpyt frederikpyt merged commit 37c4242 into master Oct 18, 2023
@frederikpyt frederikpyt deleted the fmp-21 branch October 18, 2023 10:01
@frederikpyt
Copy link
Contributor Author

Github is stupid, ignore build failing - vercel could build and I also could locally

@frederikpyt frederikpyt restored the fmp-21 branch October 18, 2023 10:08
@frederikpyt frederikpyt deleted the fmp-21 branch October 18, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anders164a Anders164a Anders164a approved these changes

Assignees

@frederikpyt frederikpyt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breadcrumb
2 participants
@frederikpyt @Anders164a