Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Azure Document Repository to route through the App Gateway #3040

Closed
wants to merge 1 commit into from

Conversation

rajohnson90
Copy link
Contributor

What changed

Previously, the app uploaded files directly to the blob storage. As part of our security efforts, we're routing document upload through the app gateway instead. At the moment there are some issues with CORS that I do not expect to be present on the dev branch because dev is deployed to the same url as the dev app gateway. Part of this PR is to test this in dev

Issue

OPS-2362

How to test

  1. Navigate to the dev page and log in as an admin user
  2. Add /upload-document to the URL
  3. upload a document via the UI
  4. verify there were no failed requests in the network tab to a URL that has UUID?se={rest of token goes here)
  5. Verify in azure doc storage that your file was uploaded under its UUID as the name

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

@rajohnson90 rajohnson90 self-assigned this Nov 7, 2024
@rajohnson90 rajohnson90 closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant