Create CANHistory endpoint #3277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajohnson90
added
python
jonnalley
reviewed
Jan 9, 2025
| @@ -31,6 +31,7 @@ services: | |||
| /bin/sh -c " | |||
| . .venv/bin/activate && | |||
| alembic upgrade head && | |||
| DATA=./data_tools/data/ops_event.json5 python ./data_tools/src/import_static_data/import_data.py | |||
There was a problem hiding this comment.
@rajohnson90 I think you'll need an && on the end of this line. That is likely why the current pipeline is failing on this
…t data seeded into dev db
rajohnson90
requested review from
jonnalley,
johndeange,
fpigeonjr,
maiyerlee,
Santi-3rd and
weimiao67
|
I missed that a single commit had a capital letter in it and there's no good way to fix it. Recreating this PR in #3288 where there is no commit-lint issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Creating /can-history endpoint so users can retrieve the history of all actions performed on can. Adding test data to the database so that the can history can be interacted with from the front end in dev environments before any can history events have been triggered.
Issue
OPS-3276
How to test
Run all tests
Definition of Done Checklist