-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schema to require budget
field on /can-funding-budgets
#3336
Merged
maiyerlee
merged 7 commits into
main
from
OPS-310/3208-can-funding-budget-endpt-req-field
Jan 28, 2025
Merged
Update schema to require budget
field on /can-funding-budgets
#3336
maiyerlee
merged 7 commits into
main
from
OPS-310/3208-can-funding-budget-endpt-req-field
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiyerlee
changed the title
Ops 310/3208 can funding budget endpt req field
Update schema to require Jan 27, 2025
budget
field on /can-funding-budgets
maiyerlee
requested review from
johndeange,
rajohnson90,
fpigeonjr,
Santi-3rd and
weimiao67
January 27, 2025 17:16
fpigeonjr
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
johndeange
approved these changes
Jan 27, 2025
rajohnson90
approved these changes
Jan 28, 2025
🎉 This PR is included in version 1.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
This will require the
budget
field on the/can-funding-budget
endpoint, as specified in the marshmallow schema.Issue
3208
How to test
Test passing.
Screenshots
N/A
Definition of Done Checklist
Links
n/A