Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema to require budget field on /can-funding-budgets #3336

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

maiyerlee
Copy link
Contributor

@maiyerlee maiyerlee commented Jan 22, 2025

What changed

This will require the budget field on the /can-funding-budget endpoint, as specified in the marshmallow schema.

Issue

3208

How to test

Test passing.

Screenshots

N/A

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

Links

n/A

@maiyerlee maiyerlee linked an issue Jan 22, 2025 that may be closed by this pull request
@maiyerlee maiyerlee self-assigned this Jan 22, 2025
@maiyerlee maiyerlee marked this pull request as ready for review January 27, 2025 16:20
@maiyerlee maiyerlee changed the title Ops 310/3208 can funding budget endpt req field Update schema to require budget field on /can-funding-budgets Jan 27, 2025
Copy link
Contributor

@fpigeonjr fpigeonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that this should be required
image

@maiyerlee maiyerlee merged commit e695e0e into main Jan 28, 2025
42 checks passed
@maiyerlee maiyerlee deleted the OPS-310/3208-can-funding-budget-endpt-req-field branch January 28, 2025 15:40
Copy link

🎉 This PR is included in version 1.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

budget is required field for POST to /can-funding-budgets endpoint
4 participants