Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert CAN History items whenever a CAN is created, CANFundingBudget is created, and CANFundingReceived is deleted #3366

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rajohnson90
Copy link
Contributor

What changed

We have hooked up the message bus to listen to the OpsEvents emitted when a CAN is created, CANFundingBudget is created, or CANFundingReceived is deleted. In addition, we've updated the prefilled ops event and can history data to better represent what they will look like in production. Additionally, found and fixed an issue where failed ops events would result in a 400 instead of being logged, giving us some false positives on other unit tests.

Issue

OPS-3276

How to test

  1. Run backend unit tests
  2. Alternatively if you can create a CAN through the API, add a CAN Funding Budget, or delete CAN FUnding Received you can also check for the existence of corresponding messages in the dbviewer while podman is running.

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

@jonnalley
Copy link
Contributor

Additionally, found and fixed an issue where failed ops events would result in a 400 instead of being logged,

@rajohnson90 @Santi-3rd that's huge 👏 👏

@jonnalley jonnalley requested a review from Santi-3rd January 25, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants