CAN History Part 2 #3386
Merged
CAN History Part 2 #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ack to can_history_trigger_func
… into history trigger
fpigeonjr
reviewed
Feb 4, 2025
There was a problem hiding this comment.
🥇 looking good, tested locally and here is what I observed:
- ✅ CAN budget added
- ✅ CAN budget edited
- ✅ CAN Funding Received added
- ❌ CAN Funding Received edited
- ✅ CAN Funding Received deleted
- ✅ CAN Nickname edited (after small delay)
- ✅ CAN Description edited (after small delay)
|
these branch names remind how I used to name my photoshop files back in da day 😅 |
|
@fpigeonjr Do you mean that editing funding received did not create an event in the history log? |
yes that is correct. |
fpigeonjr
approved these changes
Feb 7, 2025
maiyerlee
approved these changes
Feb 10, 2025
johndeange
approved these changes
Feb 10, 2025
|
🎉 This PR is included in version 1.41.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
In this PR we have added the majority of the remaining CAN History events designed by UX.
The largest part of this change was the events for updates. Updates are handled by taking the model before and after the update, serializing them, and passing them to a utility function in the ops/utils/events.py. This utility function performs a diff of the root level properties on these objects and places them into a dictionary of changes along with a few other properties required by all update changes.
Once the changes have been collected by the utility function and passed to the OpsEvent, the other biggest change is the handling of updates in the can_messages.py file. For CAN Updates, we iterate over the list of keys in the change dictionary and create a CAN History message for each changed property that we have designed around. Primarily right now this is the nickname and description of a CAN, but also portfolio. Portfolio may be moved to a different function later as it seems like the only time we expect the managing portfolio for a CAN to change is during the yearly CANBACs import.
CAN Funding and CAN Budget only check for changes to the funding received and budget respectively.
Issue
OPS-3276
How to test
Screenshots
If relevant, e.g. for a front-end feature
Definition of Done Checklist