cleanup and enable new relic in staging

HHS · Feb 27, 2025 · a807453 · a807453
1 parent 98a0656
commit a807453
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/frontend/tests/components/search/SearchAnalytics.test.tsx b/frontend/tests/components/search/SearchAnalytics.test.tsx
@@ -13,10 +13,11 @@ jest.mock("@next/third-parties/google", () => ({
 }));
 
 jest.mock("src/utils/analyticsUtil", () => ({
-  waitForNewRelic: () => waitForNewRelicMock(),
-  setNewRelicCustomAttribute: (...args) =>
+  waitForNewRelic: () => waitForNewRelicMock() as unknown,
+  setNewRelicCustomAttribute: (...args: unknown[]): unknown =>
     setNewRelicCustomAttributeMock(...args),
-  unsetAllNewRelicQueryAttributes: () => unsetAllNewRelicQueryAttributesMock(),
+  unsetAllNewRelicQueryAttributes: () =>
+    unsetAllNewRelicQueryAttributesMock() as unknown,
 }));
 
 const basicParams = {

diff --git a/frontend/tests/utils/analyticsUtils.test.ts b/frontend/tests/utils/analyticsUtils.test.ts
@@ -70,7 +70,7 @@ describe("unsetAllNewRelicQueryAttributes", () => {
     jest.resetAllMocks();
   });
   it("does not attempt to call new relic if new relic does not exist", () => {
-    unsetAllNewRelicQueryAttributes("key");
+    unsetAllNewRelicQueryAttributes();
     expect(mockSetCustomAttribute).not.toHaveBeenCalled();
   });
   it("calls new relic with passed values, with key properly prefixed", () => {

diff --git a/infra/frontend/app-config/staging.tf b/infra/frontend/app-config/staging.tf
@@ -21,9 +21,6 @@ module "staging_config" {
   # instance_scaling_max_capacity is 5x the instance_scaling_min_capacity
   instance_scaling_max_capacity = 10
 
-  service_override_extra_environment_variables = {
-    NEW_RELIC_ENABLED = "false"
-  }
   # Enables ECS Exec access for debugging or jump access.
   # See https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-exec.html
   # Defaults to `false`. Uncomment the next line to enable.