Use js env vars #153
Use js env vars #153
Conversation
|
this is live. |
|
on line 84 or so in services.js.coffee there is a window.location.replace ... change the url to the domain var |
|
on line 255 or so in services.js.coffee there is a link for the FB send dialog ... change it to the domain var |
|
FB is not defined if this is live and it's playing the same song as a result and giving a 500 if you try and create a playlist from FB event |
|
500 problem is gone. |
|
fixed the other two issues and redeployed. |
|
I think we talked about this before, but why would is it playing the same song if FB isn't live? |
| pusherKey: "#{Rails.configuration.pusher_key}" | ||
| } | ||
| }; | ||
|
|
||
| (function(d) { |
There was a problem hiding this comment.
isn't this where facebook is defined? Would putting it above the Playedbyme definition make a difference?
There was a problem hiding this comment.
it shouldn't make a difference bc neither are dependent on each other
|
It's because of continuous play - since there are no preferences due to lack of FB data, we end up searching soundcloud with an empty string and playing the first song (we'll change this later) |
| @@ -81,7 +81,7 @@ ocarinaServices.factory 'Authentication', ['$http', ($http) -> | |||
| access_token: auth.accessToken | |||
| $.get "#{apiURL}/api/users/authenticate.json", authParams, (data) -> | |||
| Authentication.setCookie("user_id", data.id, 1) | |||
| window.location.replace "http://localhost:4400?user_id=#{data.id}" | |||
| window.location.replace "http://#{Playedbyme.env.domain}:4400?user_id=#{data.id}" | |||
There was a problem hiding this comment.
drop the :4400 - for some reason this is still redirecting me in login to localhost
|
FB is still not working - I'll try and investigate tomorrow morning |
|
could it be that we're using old fb permissions on staging? |
|
what do you mean old fb permissions? Basil Siddiqui @BasilKSiddiqui On Thu, Oct 10, 2013 at 12:30 PM, Matthew Nguyen
|
|
when we first signed up on the staging server, i think we were using different fb permissions than the ones we are using now. |
|
FB permissions are determined by the app, not what you put when registering On Thu, Oct 10, 2013 at 3:41 PM, Matthew Nguyen [email protected]:
|
Conflicts: app/views/layouts/application.html.haml
Conflicts: app/views/layouts/application.html.haml
Conflicts: app/views/layouts/application.html.haml
…o feature/js-env-vars Conflicts: app/assets/javascripts/services.js.coffee app/views/layouts/application.html.haml
@bsiddiqui