Package publisher as container #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markiantorno this is for you when you rebuild the pipelines |
|
Any update on this? Or any way I can help integrate a container build into the ci pipeline? |
|
@markiantorno is still working on dockerizing the validator. We'll work on dockerizing the publisher once that's settled |
lmckenzi
added
enhancement
|
Is this PR still a thing? |
|
@jkiddo not in this form. There appears to be a current and better maintained dockerized publisher here: https://github.com/FHIR/auto-ig-builder/blob/master/images/ig-publisher-base/Dockerfile I feel as though that should be used in place of this one, but have yet to discuss it with @jmandel |
|
It says 'latest-sushi' - wouldnt it be in favour to have that narrowed down to a specific version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93
To make this really useful, this repository should be connected to Docker Hub to automatically build and publish the container image.