WIP: Elevation fixes #314
Open
WIP: Elevation fixes #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
optionsome
commented
Jun 27, 2019
•
optionsome
commented
- Changes made at entur for using elevation in splitted edges and some refactoring.
- Fix for using correct part of the parent edge's elevation values when splitting instead of always using the elevation values from start to split edge's length
- Fixed issues causing elevation values from a step to exceed in distance the step's actual distance
- Fixed elevation gained and lost calculation to match what is returned in steps' elevation values
- Remove elevation points within steps that are too close to each other (distance between them is <5m)
- Fixed missing elevation after destructive splits (bike rental station or car park is added)
…it. This apply to biking and walking.
…n edge. - Push assigning 'wheelchairAccessible' into the 'TemporarySplitterVertex' constructor. - Create constructor for temporary street edge without a pre-calculated length, calculate length from the geometry in this case. - Update some comments
…ialStreetEdge, witch were the only place it was used except for tests. - Simplified the constructors a bit.
|
There are some relevant pull requests in upstream that could be used to replace some of the changes I've made in this pr (opentripplanner#2791 and opentripplanner#2752) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.