Fetch Docker Compose bundle from jore4-docker-compose-bundle repository
#43
Conversation
…, as the directory has already been checked into version control.
"jore4-docker-compose-bundle" repository.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @culka and @janneronkko)
development.sh line 35 at r1 (raw file):
# First, try to find a commit on GitHub that matches the given reference. # This function exits with an error code if no matching commit is found. local commit_sha
The local variable declaration is on a separate line so as not to mask the return value of the gh api call.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @culka and @janneronkko)
development.sh line 37 at r1 (raw file):
local commit_sha commit_sha=$( gh api \
The gh api call also prints a meaningful error message containing an invalid reference if a matching commit is not found.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @culka)
This change is