Accessibility misc button focus fixes #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niknii-vincit
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @culka)
-- commits line 21 at r3:
Typo nitpick, do as you wish 😄 Otherwise these have been great descriptions!
Suggestion:
around
culka
commented
Mar 4, 2024
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niknii-vincit)
Previously, niknii-vincit (Niki Niittymäki) wrote…
Typo nitpick, do as you wish 😄 Otherwise these have been great descriptions!
Fixed 📍
EditButton had it's area as a square with large left margin despite the button proper being a round button. Move the margin from inside the link element to the outside and apply round style to the whole element to fix focus display.
Add route had it's area as a square with large left margin despite the button proper being a round button. Move the margin from inside the link element to the outside and apply round style to the whole element to fix focus display
Fix alignment of the focus selection on the timing place button on route stops -row, and make it round around the button itself, not square around the whole area.
- Change padding to margin so the button area is the actual button - Remove focus:outline-none - Use rounded area for button
Show selection on headlessui simple dropdown menu
culka
force-pushed
the
accessibility-misc-button-focus-fixes
branch
from
afeac9d to
5a199f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multiple focus issues with buttons and dropdown selection.
This change is