Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Improvements #977

Merged
merged 5 commits into from
Jan 21, 2025
Merged

E2E: Improvements #977

merged 5 commits into from
Jan 21, 2025

Conversation

Huulivoide
Copy link
Contributor

@Huulivoide Huulivoide commented Jan 20, 2025

Add close button to Toasts

E2E: Add missing 'Save succeeded' check

E2E: StopAreas - Wait for loaders to close on beforeEach

E2E: Avoid unneeded cy.wrap calls on arrays

E2E: Replace all old Toas message checks with proper expections

The old way would silently fail in case a toas of different type spawned on screen. For example if a form save failed, instead of being notified about that, Cypress would just say that the success Toas was newer on screen.


This change is Reviewable

The old way would silently fail in case a toas of different type
spawned on screen. For example if a form save failed, instead of being
notified about that, Cypress would just say that the success Toas was
newer on screen.
@Huulivoide Huulivoide changed the title E2E: Replace all old Toas message checks with proper expections E2E: Improvements Jan 20, 2025
Copy link
Contributor

@culka culka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Huulivoide)


-- commits line 16 at r1:
nit: never

@Huulivoide Huulivoide merged commit bf91465 into main Jan 21, 2025
9 of 10 checks passed
@Huulivoide Huulivoide deleted the AlwaysExpectAToast branch January 21, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants