Skip to content

Commit

Permalink
fix linting
Browse files Browse the repository at this point in the history
  • Loading branch information
sarahfossheim committed Oct 23, 2024
1 parent bf11a13 commit ce8df02
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 14 deletions.
2 changes: 1 addition & 1 deletion server/routes.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def techreportlanding(page_id):
# Get the settings for the current page
active_tech_report = tech_report.get("pages").get(page_id)

# Add the technologies requested in the URL to the filters
# Add the technologies requested in the URL to the filters
# Use the default configured techs as fallback
# Use ["ALL"] if there is nothing configured
requested_technologies = active_tech_report.get("config").get("default").get(
Expand Down
7 changes: 0 additions & 7 deletions src/js/components/filters.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,6 @@ class Filters {
techSelector.append(optionTmpl);
});
}

console.log('set selected tech')
/* Get the selected technology */
const selected = techSelector.dataset.selected;
console.log('selected', selected);
console.log(techSelector.querySelector(`option[value="${selected}"]`));
techSelector.querySelector(`option[value="${selected}"]`).selected = true;
});
}

Expand Down
6 changes: 2 additions & 4 deletions src/js/techreport/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ class TechReport {
getAllMetricData() {
const technologies = this.filters.app;

const base = 'https://prod-gw-2vzgiib6.ue.gateway.dev/v1';
const apis = [
{
endpoint: 'cwv',
Expand Down Expand Up @@ -276,8 +275,7 @@ class TechReport {
}

getCategoryData(category) {
const base = 'https://prod-gw-2vzgiib6.ue.gateway.dev/v1';
const url = `${base}/categories?category=${category}`;
const url = `${Constants.apiBase}/categories?category=${category}`;
const apis = [
{
endpoint: 'cwv',
Expand Down Expand Up @@ -317,7 +315,7 @@ class TechReport {
category.technologies.forEach(tech => allResults[tech] = []);

Promise.all(apis.map(api => {
const url = `${base}/${api.endpoint}?technology=${technologyFormatted}&geo=${geoFormatted}&rank=${rankFormatted}`;
const url = `${Constants.apiBase}/${api.endpoint}?technology=${technologyFormatted}&geo=${geoFormatted}&rank=${rankFormatted}`;

return fetch(url)
.then(techResult => techResult.json())
Expand Down
3 changes: 1 addition & 2 deletions static/css/techreport/techreport.css
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ nav {
}

#page-filters .meta {

padding-top: 1rem;
}

Expand Down Expand Up @@ -687,7 +686,7 @@ select {
}

#close-filters:is(:hover, :focus-visible) {
border: 1px solid var(--color-button-background);
border: 1px solid var(--color-button-background);
}

/* Results header */
Expand Down

0 comments on commit ce8df02

Please sign in to comment.