Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content and styling improvements #881

Merged
merged 19 commits into from
Aug 9, 2024
Merged

Content and styling improvements #881

merged 19 commits into from
Aug 9, 2024

Conversation

sarahfossheim
Copy link
Contributor

@sarahfossheim sarahfossheim commented Jun 11, 2024

PR includes:

@rviscomi rviscomi marked this pull request as draft June 12, 2024 14:00
@rviscomi rviscomi marked this pull request as ready for review July 24, 2024 13:34
@rviscomi
Copy link
Member

Found during the meeting: the reports dropdown is behind the input fields, so moving the cursor over it closes the dropdown menu

Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor suggestions

src/js/techreport/index.js Outdated Show resolved Hide resolved
const technology = technologies.join('%2C')
.replaceAll(" ", "%20");

const base = 'https://prod-gw-2vzgiib6.ue.gateway.dev/v1';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is defined in a few places. In case we ever need to update the API host, could this be pulled up into a high-level constant?

@rviscomi rviscomi merged commit df56a3d into main Aug 9, 2024
10 checks passed
@rviscomi rviscomi deleted the cwvtech-improvements branch August 9, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants