-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content and styling improvements #881
Conversation
Found during the meeting: the reports dropdown is behind the input fields, so moving the cursor over it closes the dropdown menu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor suggestions
src/js/techreport/index.js
Outdated
const technology = technologies.join('%2C') | ||
.replaceAll(" ", "%20"); | ||
|
||
const base = 'https://prod-gw-2vzgiib6.ue.gateway.dev/v1'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is defined in a few places. In case we ever need to update the API host, could this be pulled up into a high-level constant?
Co-authored-by: Rick Viscomi <[email protected]>
…s' into cwvtech-improvements
PR includes:
Solves: Beta report formatting of large numbers and dates #865
ALL
, render the tech name as 'All Technologies' insteadSolves: Rename "ALL" to "All technologies" #852