Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-image support for llama3.2 #705

Open
wants to merge 9 commits into
base: habana_main
Choose a base branch
from
Open

multi-image support for llama3.2 #705

wants to merge 9 commits into from

Conversation

yma11
Copy link

@yma11 yma11 commented Jan 20, 2025 •
edited by github-actions bot
Loading

No description provided.

@yma11 yma11 force-pushed the multi-image branch 3 times, most recently from 8477d17 to 08541ff Compare January 24, 2025 01:58
@yma11
Copy link
Author

yma11 commented Jan 24, 2025

@kdamaszk @michalkuligowski @kzawora-intel, can you help review on this PR? Already tested on 11B and 90B.

@yma11 yma11 force-pushed the multi-image branch 3 times, most recently from c9bfe70 to 7223fb8 Compare January 26, 2025 07:38
@kdamaszk
Copy link

kdamaszk commented Jan 27, 2025 •
edited
Loading

@yma11 I observed accuracy regression on MMMU val dataset and LLama 3.2 11B Vision Instruct. Let's sync offline
EDIT: not visible anymore

@yma11 yma11 force-pushed the multi-image branch 2 times, most recently from 69411f3 to 0c2759e Compare January 31, 2025 10:06
kdamaszk
kdamaszk approved these changes Jan 31, 2025
View reviewed changes
Copy link

@kdamaszk kdamaszk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdamaszk
Copy link

kdamaszk commented Feb 3, 2025

@PatrykWo please review

@PatrykWo
Copy link

PatrykWo commented Feb 4, 2025

@kdamaszk I see some errors in CI. Please rebase with the base branch so you are up to date and we can confirm that new changes does not influence the PR.

@kdamaszk
Copy link

kdamaszk commented Feb 4, 2025

@PatrykWo please note that CI will fail for the jenkins tests, as @yma11 submitted this PR from personal fork. There is a known issue with running CI tests in such case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdamaszk kdamaszk kdamaszk approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@madamczykhabana madamczykhabana Awaiting requested review from madamczykhabana madamczykhabana is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz mgawarkiewicz is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yma11 @kdamaszk @PatrykWo