make benchmark_throughput static support single image input #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yma11
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
yma11
force-pushed
the
benchmark_image
branch
3 times, most recently
from
2ae39d5 to
820b5dd
Compare
|
@kdamaszk Can you also help review this PR? |
kdamaszk
reviewed
Jan 27, 2025
There was a problem hiding this comment.
@michalkuligowski @kzawora-intel please review, this PR modifies native vllm benchmark. Is that ok?
benchmarks/benchmark_throughput.py
Outdated
| @@ -363,35 +374,46 @@ def main(args: argparse.Namespace): | |||
| lora_request, lora_tokenizer = get_random_lora_request(args) | |||
| if lora_tokenizer: | |||
| request_tokenizer = lora_tokenizer | |||
|
|
|||
| if args.mm_data: | |||
kdamaszk
reviewed
Jan 27, 2025
benchmarks/benchmark_throughput.py
Outdated
| lora_request=lora_request)) | ||
| if mm_data is not None: | ||
| requests.append( | ||
| SampleRequest(prompt="<|image|><|begin_of_text|>" + candidate_prompt, |
Signed-off-by: yan ma <[email protected]>
Signed-off-by: yan ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.