Review Manager - In App Review #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial Check: When determing to request a in-app review, first check if an initial review request has been made. If no review has been requested before, the app takes note of the current number of user check-ins and proceeds to request a review on the next startup during the next logical break. Logical Breaks: After the initial in-app review request, wait for a logical break before potentially asking the user again. This is to ensure we don't pester them :) Limit on Total Review Requests: Request a review only up to 5 times. After that, it will not prompt the player for reviews anymore (Unless a user has checked-in 75 times before requesting 5 in-app reviews). Check-in Limit Since First Review: If a user has checked in more than 75 times since the very first review was requested, the app won't request another review. This is to ensure that players are not continuously prompted. Gap Between Review Requests: Once a review has been requested, wait until the player has checked in at least 5 more times before considering another review request. This ensures a decent gap between consecutive review prompts.
phillipthelen
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Left some comments. But looks good so far!
We should also change it to use Hilt for the dependency injection.
Steps for that:
- add @Inject to the
latent var reviewManager: ReviewManagerlines - Remove the initialisations
- add the following code to the AppModule.kt file
@Provides
fun providesReviewManager(@ApplicationContext context: Context): ReviewManager {
return ReviewManager(context)
}
That should already be enough to get the ReviewManager available through hilt
| if (!shouldQueueReview) { | ||
| // First review request has been made, wait for following request (if any) | ||
| // to request again in the spirit of asking during a logical break. | ||
| sharedPref.edit().putBoolean(SHOULD_QUEUE_REVIEW, true).apply() |
There was a problem hiding this comment.
Should use kotlins edit {} shorthand/function
|
|
||
| if (initialCheckins == -1) { | ||
| // Store the current checkins as the initial value | ||
| sharedPref.edit().putInt(INITIAL_CHECKINS_KEY, currentCheckins).apply() |
There was a problem hiding this comment.
Should use kotlins edit {} shorthand/function
| } | ||
|
|
||
| // Save the current checkins after a successful review request | ||
| sharedPref.edit().putInt(LAST_REVIEW_CHECKIN_KEY, currentCheckins).apply() |
There was a problem hiding this comment.
Should use kotlins edit {} shorthand/function
|
|
||
| private fun incrementReviewRequestCount() { | ||
| val currentCount = sharedPref.getInt(REVIEW_REQUEST_COUNT_KEY, 0) | ||
| sharedPref.edit().putInt(REVIEW_REQUEST_COUNT_KEY, currentCount + 1).apply() |
There was a problem hiding this comment.
Should use kotlins edit {} shorthand/function
| if (args.type == "gear") { | ||
| userViewModel.user.observeOnce(this) { user -> | ||
| val totalCheckIns = user?.loginIncentives | ||
| if (totalCheckIns != null) { |
There was a problem hiding this comment.
user?.loginIncentives?.let { totalCheckins ->
}
This would be a slightly more concise/kotlin version
|
|
||
| private fun checkForReviewPromptAfterClassSelection() { | ||
| userViewModel.user.observeOnce(this) { user -> | ||
| val totalCheckIns = user?.loginIncentives ?: return@observeOnce |
There was a problem hiding this comment.
This version also works (see my other comment. But I think we should stick to one way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-App Review manager logic -
Initial Check:
When determing to request a in-app review, first check if an initial review request has been made.
If no review has been requested before, the app takes note of the current number of user check-ins and proceeds to request a review on the next startup during the next logical break.
Logical Breaks:
After the initial in-app review request, wait for a logical break before potentially asking the user again. This is to ensure we don't pester them :)
Limit on Total Review Requests:
Request a review only up to 5 times. After that, it will not prompt the player for reviews anymore (Unless a user has checked-in 75 times before requesting 5 in-app reviews).
Check-in Limit Since First Review:
If a user has checked in more than 75 times since the very first review was requested, the app won't request another review. This is to ensure that players are not continuously prompted.
Gap Between Review Requests:
Once a review has been requested, wait until the player has checked in at least 5 more times before considering another review request. This ensures a decent gap between consecutive review prompts.