Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default LED behavior #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

baileysage
Copy link

  • Made LED behavior in boot.py match what was in comments.
  • Prevented a half lit board after test spiral when touchwheel not on badge.
  • Prevented RGB LED from visibly blinking when touchwheel is on badge.

@hexagon5un
Copy link
Member

Hi Bailey,

This pull request wraps up a bunch of different changes into one, and that makes it hard to cherry-pick among them.

Someone else already submitted a fix for the LEDs-left-on problem, so this clashes with the other.

I'm also not sure what the RGB blinking fix is about -- the idea was to confirm that the touchwheel was found by blinking the LED. Although maybe that's not necessary any more, because Todbot sped up the touchwheel's boot up sequence before the badge's production run. I'll have to think about that one.

@baileysage
Copy link
Author

Each change is in its own commit, so it should be fairly easy to cherry-pick them individually, but I do see how they are quite overwhelming taken in full!

I can remove 63f5317 and 1b2cac5 so I don't conflict with others' changes for turning off the lights at the end of the test spiral.

The blinking was because the button presses for the RGB light and the touch wheel press for the spiral lights were stomping on each other and they were alternating on and off each loop if you held a button down. Your commit 31b237a will make the RGB blink again, but not the spiral lights. I could (maybe should) have read the line status from the chip before each write instead of keeping it locally. Plus, there are plenty of examples out there on how to interact with the SAO more gracefully since I made this PR, so I am happy to remove that change 0a158bb.

I'll rebase my branch without those commits after I'm done with work for the day!

@baileysage
Copy link
Author

Rebased with changes from the parent branch, removed unnecessary commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants