Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

248 add character limit on project names #251

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

hgutha
Copy link
Contributor

@hgutha hgutha commented Jul 23, 2024

I added margin-left and margin-right spacing (mx) to the project Name in judgingBox. I know the issue description says to limit project name so I also limited Project Name to be 30 characters.

Is this what was expected?

@hgutha hgutha linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Jul 23, 2024

Deploying timber with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0952afb
Status: ✅  Deploy successful!
Preview URL: https://5317635f.timber.pages.dev
Branch Preview URL: https://248-add-character-limit-on-p.timber.pages.dev

View logs

src/util/util.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ganning127 ganning127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments above 🙂

@hgutha hgutha requested a review from ganning127 July 23, 2024 04:26
@lyangji1011 lyangji1011 merged commit a0fb41a into main Jan 27, 2025
2 checks passed
@lyangji1011 lyangji1011 deleted the 248-add-character-limit-on-project-names branch January 27, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Character limit on project names
3 participants