Skip to content
This repository has been archived by the owner on Jun 21, 2019. It is now read-only.

Allow admins to enabled / disabled endpoints #168

Open
wants to merge 17 commits into
base: staging
Choose a base branch
from
Open

Allow admins to enabled / disabled endpoints #168

wants to merge 17 commits into from

Conversation

ASankaran
Copy link
Contributor

@ASankaran ASankaran commented Nov 24, 2017 •
edited
Loading

Pull request implements the features described in #131.

  • Add endpoint for enabling and disabling other endpoints
  • Access to this feature is restricted to admins
  • Allow admins to query state of an endpoint
  • Maintain endpoint state in SQL database
  • Cache endpoint states in redis cache for faster access
  • Block access to disabled endpoints, return an error
  • Log enabling and disabling of endpoints

@ASankaran
Added endpoint for enabling and disabling endpoints
eea41f1
@ASankaran
Added middleware to block access to disabled endpoints
a9a5be9
@ASankaran
Fixed comparism
573225f
@ASankaran
Added migration and revert scripts
bcb1d01
@ASankaran
Update endpoint states in database
46c0127
@ASankaran
Read / Write endpoint states from database. Disabled reddis caching o…
ddf2f05 
…f state.
@ASankaran
Added endpoint state to response
f00c888
@ASankaran
Added function to check state of endpoint
33ef933
@ASankaran
Use cacheing for endpoint states
aca6eef
@ASankaran
Fixed commented out admin restrictions
4b66385
@ASankaran
Restricted enabling / disabling of endpoints to admin
3b1dd37
@ASankaran
Fixed linter errors
0ffded4
@ASankaran
Moved querying of endpoint state to GET request
642486f
@ASankaran
Log when an admin enabled / disables an endpoint
e30a4f6
@ASankaran
Fixed lint errors
d35923e
@ASankaran
Removed timestamps for endpoints in db
9ef1d43
@ASankaran
Moved endpoint code into service
2772092
YashoSharma
YashoSharma suggested changes Feb 9, 2018
View reviewed changes
Copy link
Member

@YashoSharma YashoSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I began reviewing this, but there are still console.log debug statements, let me know when this is ready for code review.

Additionally move this to a feature/EndpointAccess branch on Hackillinois/api

database/migration/V20171121_1645__addEndpointToggle.sql
@@ -0,0 +1,5 @@
CREATE TABLE `endpoints` (
`endpoint` VARCHAR(50) NOT NULL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's up this to 127 to leave a healthy margin

database/migration/V20171121_1645__addEndpointToggle.sql
@@ -0,0 +1,5 @@
CREATE TABLE `endpoints` (
`endpoint` VARCHAR(50) NOT NULL,
`enabled` BIT(1),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use TINYINT(1) for consistency with the rest of the schema

database/migration/V20171121_1645__addEndpointToggle.sql
@@ -0,0 +1,5 @@
CREATE TABLE `endpoints` (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint_state

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YashoSharma YashoSharma YashoSharma requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ASankaran @YashoSharma